lollipopjin commented on code in PR #9256:
URL: https://github.com/apache/rocketmq/pull/9256#discussion_r2052122492
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -3479,129 +3478,24 @@ private boolean
validateBlackListConfigExist(Properties properties) {
private CheckRocksdbCqWriteResult
doCheckRocksdbCqWriteProgress(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
CheckRocksdbCqWriteProgressRequestHeader requestHeader =
request.decodeCommandCustomHeader(CheckRocksdbCqWriteProgressRequestHeader.class);
- String requestTopic = requestHeader.getTopic();
MessageStore messageStore = brokerController.getMessageStore();
DefaultMessageStore defaultMessageStore;
if (messageStore instanceof AbstractPluginMessageStore) {
defaultMessageStore = (DefaultMessageStore)
((AbstractPluginMessageStore) messageStore).getNext();
} else {
defaultMessageStore = (DefaultMessageStore) messageStore;
}
- RocksDBMessageStore rocksDBMessageStore =
defaultMessageStore.getRocksDBMessageStore();
- CheckRocksdbCqWriteResult result = new CheckRocksdbCqWriteResult();
+ ConsumeQueueStoreInterface consumeQueueStore =
defaultMessageStore.getQueueStore();
- if
(defaultMessageStore.getMessageStoreConfig().getStoreType().equals(StoreType.DEFAULT_ROCKSDB.getStoreType()))
{
- result.setCheckResult("storeType is DEFAULT_ROCKSDB, no need
check");
+ if (!(consumeQueueStore instanceof CombineConsumeQueueStore)) {
+ CheckRocksdbCqWriteResult result = new CheckRocksdbCqWriteResult();
+ result.setCheckResult("is not CombineConsumeQueueStore, no need
check");
Review Comment:
It's not CombineConsumeQueueStore, no need to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
