lizhimins commented on code in PR #8130:
URL: https://github.com/apache/rocketmq/pull/8130#discussion_r1606282322
##########
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##########
@@ -515,6 +519,33 @@ public void updateTopicConfig(final TopicConfig
topicConfig) {
this.persist(topicConfig.getTopicName(), topicConfig);
}
+ private synchronized void updateTieredStoreTopicMetadata(final TopicConfig
topicConfig, Map<String, String> newAttributes) {
+ if (!(brokerController.getMessageStore() instanceof
TieredMessageStore)) {
+ if
(newAttributes.get(TopicAttributes.TOPIC_RESERVE_TIME_ATTRIBUTE.getName()) !=
null) {
+ throw new IllegalArgumentException("Update topic reserveTime
not supported");
Review Comment:
tiered storage feature is optional, should not throw exception here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
