This is an automated email from the ASF dual-hosted git repository.
pradeep pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git
The following commit(s) were added to refs/heads/master by this push:
new f074e4277 RANGER-5280: Fix for test case failure in
TestKMSMetricsWrapper (#625)
f074e4277 is described below
commit f074e4277d744a2ee526d24068f878fa0e409c9b
Author: Vikas Kumar <[email protected]>
AuthorDate: Fri Aug 8 19:10:26 2025 +0530
RANGER-5280: Fix for test case failure in TestKMSMetricsWrapper (#625)
---
.../ranger/kms/metrics/TestKMSMetricsWrapper.java | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git
a/kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java
b/kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java
index 0009e28fa..ca1233133 100644
--- a/kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java
+++ b/kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java
@@ -44,6 +44,10 @@ public TestKMSMetricsWrapper() {
public void testNonThreadsafeCounterMetrics() throws NoSuchFieldException,
IllegalAccessException {
// set the "isMetricCollectionThreadsafe" value to true to verify
different flow.
setKmsMetricsCollectorThreadSafelyFlag(false);
+ DefaultMetricsSystem.instance().publishMetricsNow();
+
+ long prevKeyCreateCount = (long)
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_COUNT.getKey());
+ long prevKeyCreateElapsedTime = (long)
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_ELAPSED_TIME.getKey());
// For COUNTER type
kmsMetricsCollector.incrementCounter(KMSMetrics.KMSMetric.KEY_CREATE_COUNT);
@@ -53,14 +57,21 @@ public void testNonThreadsafeCounterMetrics() throws
NoSuchFieldException, Illeg
DefaultMetricsSystem.instance().publishMetricsNow();
- Assertions.assertEquals(1L,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_COUNT.getKey()));
- Assertions.assertEquals(100L,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_ELAPSED_TIME.getKey()));
+ long expectedKeyCreateCount = prevKeyCreateCount + 1;
+ long expectedKeyCreateElapsedTime = prevKeyCreateElapsedTime + 100L;
+
+ Assertions.assertEquals(expectedKeyCreateCount,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_COUNT.getKey()));
+ Assertions.assertEquals(expectedKeyCreateElapsedTime,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_ELAPSED_TIME.getKey()));
}
@Test
public void testThreadsafeCounterMetrics() throws NoSuchFieldException,
IllegalAccessException {
// set the "isMetricCollectionThreadsafe" value to true to verify
different flow.
setKmsMetricsCollectorThreadSafelyFlag(true);
+ DefaultMetricsSystem.instance().publishMetricsNow();
+
+ long prevKeyCreateCount = (long)
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_COUNT.getKey());
+ long prevKeyCreateElapsedTime = (long)
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_ELAPSED_TIME.getKey());
// For COUNTER type
kmsMetricsCollector.incrementCounter(KMSMetrics.KMSMetric.KEY_CREATE_COUNT);
@@ -70,8 +81,11 @@ public void testThreadsafeCounterMetrics() throws
NoSuchFieldException, IllegalA
DefaultMetricsSystem.instance().publishMetricsNow();
- Assertions.assertEquals(1L,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_COUNT.getKey()));
- Assertions.assertEquals(200L,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_ELAPSED_TIME.getKey()));
+ long expectedKeyCreateCount = prevKeyCreateCount + 1;
+ long expectedKeyCreateElapsedTime = prevKeyCreateElapsedTime + 200L;
+
+ Assertions.assertEquals(expectedKeyCreateCount,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_COUNT.getKey()));
+ Assertions.assertEquals(expectedKeyCreateElapsedTime,
kmsMetricWrapper.getRangerMetricsInJsonFormat().get("KMS").get(KMSMetrics.KMSMetric.KEY_CREATE_ELAPSED_TIME.getKey()));
}
private void setKmsMetricsCollectorThreadSafelyFlag(boolean
isMetricCollectionThreadsafe) throws IllegalAccessException,
NoSuchFieldException {
