This is an automated email from the ASF dual-hosted git repository.

madhan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git


The following commit(s) were added to refs/heads/master by this push:
     new fa1532e9d RANGER-4691: updated GDS validation to allow dataset admins 
to create DatashareInDataset with REQUESTED status
fa1532e9d is described below

commit fa1532e9d282ba1b3d32e219b4fcbbf283862895
Author: Anand Nadar <[email protected]>
AuthorDate: Wed Feb 7 19:00:04 2024 -0800

    RANGER-4691: updated GDS validation to allow dataset admins to create 
DatashareInDataset with REQUESTED status
    
    Signed-off-by: Madhan Neethiraj <[email protected]>
---
 .../java/org/apache/ranger/validation/RangerGdsValidator.java     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java
 
b/security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java
index a42a11ffb..3632f9de4 100755
--- 
a/security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java
+++ 
b/security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java
@@ -411,9 +411,6 @@ public class RangerGdsValidator {
         }
 
         if (dataShare != null && dataset != null && 
!dataProvider.isAdminUser()) {
-            if (!dataProvider.isServiceAdmin(dataShare.getService()) && 
!dataProvider.isZoneAdmin(dataShare.getZone())) {
-                validateAdmin(dataProvider.getCurrentUserLoginId(), 
"dataShare", dataShare.getName(), dataShare.getAcl(), result);
-            }
 
             switch (dshid.getStatus()) {
                 case GRANTED:
@@ -426,8 +423,11 @@ public class RangerGdsValidator {
                     validateAdmin(dataProvider.getCurrentUserLoginId(), 
"dataset", dataset.getName(), dataset.getAcl(), result);
                 break;
 
-                case NONE:
                 case REQUESTED:
+                    validateAdmin(dataProvider.getCurrentUserLoginId(), 
"dataset", dataset.getName(), dataset.getAcl(), result);
+                break;
+
+                case NONE:
                 default:
                 break;
             }

Reply via email to