Dream95 opened a new pull request, #26001:
URL: https://github.com/apache/pulsar/pull/26001
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. The valid
`[type]` and `[component]`/scope
prefixes are enforced by CI (see
`.github/workflows/ci-semantic-pull-request.yml`); for details,
see *[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- The **Motivation** and **Modifications** sections are required: explain
*why* (the problem/context)
and *what/how* (the change). A title alone, or a description that only
restates the title, is not enough.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- For the local build/test/PR workflow see `CONTRIBUTING.md`, and for
coding conventions see
`CODING.md`. If you use an AI coding assistant, see `AGENTS.md`.
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes/closes an issue — use "Fixes #xyz" or,
equivalently, "Closes #xyz", -->
<!-- or this PR is one task of an issue -->
<!-- If the PR belongs to a PIP, please add the PIP link here -->
<!-- Details of when a PIP is required and how the PIP process work, please
see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
This fixes a bug in `MultiTopicsConsumerImpl.doAcknowledge(List<MessageId>,
...)`.
When batch acknowledging messages across multiple topics, the success
callback used
`messageIdList.forEach(unAckedMessageTracker::remove)` instead of
`messageIds.forEach(unAckedMessageTracker::remove)`. As a result, after one
underlying
consumer ack succeeded, **all** messages in the batch were removed from
`unAckedMessageTracker`, including messages that had not yet been acked by
other consumers.
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
### Modifications
- In `MultiTopicsConsumerImpl.doAcknowledge(List<MessageId>, ...)`, remove
only the per-consumer
`messageIds` from `unAckedMessageTracker` after a successful ack.
- Add `testBatchAcknowledgeRemovesOnlyAckedMessageIdsFromTracker` to verify
that completing one
consumer's batch ack leaves the other consumer's message in the tracker.
<!-- Describe the modifications you've done. -->
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
~~~
./gradlew :pulsar-client-original:test --tests
org.apache.pulsar.client.impl.MultiTopicsConsumerImplTest.testBatchAcknowledgeRemovesOnlyAckedMessageIdsFromTracker
~~~
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
