lhotari commented on code in PR #25990:
URL: https://github.com/apache/pulsar/pull/25990#discussion_r3388883485
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -1464,20 +1463,15 @@ public PersistentTopic getTopic() {
}
- public synchronized long getDelayedTrackerMemoryUsage() {
+ public long getDelayedTrackerMemoryUsage() {
Review Comment:
I reported #25991 about the RoaringBitmap thread-safety issue across the
code base. The solution would be to use ReadWriteLock and ensure that read lock
is only used for methods that never mutate internal state. It's requires
internal knowledge of the RoaringBitmap implementation to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
