BewareMyPower commented on code in PR #25922:
URL: https://github.com/apache/pulsar/pull/25922#discussion_r3353059865
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1198,6 +1199,18 @@ public void openCursorComplete(ManagedCursor cursor,
Object ctx) {
} else {
// if subscription exists, check if it's a non-durable
subscription
if (subscription.getCursor() != null &&
!subscription.getCursor().isDurable()) {
+ ledger.asyncDeleteCursor(encodedSubscriptionName, new
DeleteCursorCallback() {
+ @Override
+ public void deleteCursorComplete(Object ctx) {
+ }
+
+ @Override
+ public void
deleteCursorFailed(ManagedLedgerException exception, Object ctx) {
+ log.warn().attr("subscription",
subscriptionName)
+ .exceptionMessage(exception)
+ .log("Failed to delete cursor for
conflicts");
+ }
+ }, null);
Review Comment:
Ah, that's the concern, let me rethink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
