lhotari commented on code in PR #25575:
URL: https://github.com/apache/pulsar/pull/25575#discussion_r3146948970
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImpl.java:
##########
@@ -297,6 +302,30 @@ public PulsarAdminBuilder description(String description) {
return this;
}
+ @Override
+ public PulsarAdminBuilder socks5ProxyAddress(InetSocketAddress
socks5ProxyAddress) {
+ this.conf.setSocks5ProxyAddress(socks5ProxyAddress);
+ return this;
+ }
+
+ @Override
+ public PulsarAdminBuilder socks5ProxyUsername(String socks5ProxyUsername) {
+ this.conf.setSocks5ProxyUsername(socks5ProxyUsername);
+ return this;
+ }
+
+ @Override
+ public PulsarAdminBuilder socks5ProxyPassword(String socks5ProxyPassword) {
+ this.conf.setSocks5ProxyPassword(socks5ProxyPassword);
+ return this;
+ }
+
+ @Override
+ public PulsarAdminBuilder socks5ProxyScope(Socks5ProxyScope
socks5ProxyScope) {
+ this.conf.setSocks5ProxyScope(socks5ProxyScope);
+ return this;
+ }
Review Comment:
There's no need to modify Socks5ProxyScope for PulsarAdminBuilder. It only
applies to Pulsar client.
For PulsarAdminBuilder, the value should always be Socks5ProxyScope.HTTP_ONLY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
