nodece commented on code in PR #25245:
URL: https://github.com/apache/pulsar/pull/25245#discussion_r3146848949
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/PulsarClientTool.java:
##########
@@ -96,23 +98,8 @@ public static class RootParams {
@ArgGroup(exclusive = false)
protected RootParams rootParams = new RootParams();
- boolean tlsAllowInsecureConnection;
- boolean tlsEnableHostnameVerification;
- String tlsKeyFilePath;
- String tlsCertificateFilePath;
-
-
- // for tls with keystore type config
- boolean useKeyStoreTls;
- String tlsTrustStoreType;
- String tlsTrustStorePath;
- String tlsTrustStorePassword;
- String tlsKeyStoreType;
- String tlsKeyStorePath;
- String tlsKeyStorePassword;
- String sslFactoryPlugin;
- String sslFactoryPluginParams;
+ protected Properties properties;
Review Comment:
Good catch. This PR has been updated. Both the
`PulsarAdminPropertiesProvider` and `PulsarClientPropertiesProvider` provide
properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
