MukundaKatta opened a new pull request, #1485: URL: https://github.com/apache/pulsar-client-go/pull/1485
## Why Closes apache/pulsar#23643. The current `Producer.SendAsync` GoDoc says "This call is blocked when the `maxPendingMessages` becomes full (default: 1000)" without context, which makes the asynchronous API sound blocking by default. As noted in the issue thread, the call only blocks when the queue is full **and** `DisableBlockIfQueueFull` is left at its default (`false`). It also never says, in plain words, that the send happens in the background and the callback is what signals completion — which is the actual mental model users need. ## What `pulsar/producer.go`: - Add a one-sentence lead clarifying that `SendAsync` runs the send in the background and invokes the supplied callback on completion (success or failure). - Qualify the existing "is blocked when `maxPendingMessages` becomes full" sentence with the `DisableBlockIfQueueFull` exception, instead of describing it as unconditional. The context paragraph, callback description, example, and signature are intentionally untouched. ## Tested - Verified the GoDoc renders as expected by reading the diff (`gh api .../compare/...` shows +5 / -2 in `pulsar/producer.go`). - No code paths changed, so no test impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
