dwarburt opened a new pull request, #572:
URL: https://github.com/apache/pulsar-client-cpp/pull/572
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #570
### Motivation
My application using pulsar-client-cpp reads the version number to generate
some diagnostic logs. This worked fine when I was building pulsar-client-cpp
from source, but I've switched to building against the debian packages and the
build failed when pulsar/Version.h was missing.
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
### Modifications
The debian packaging scripts grab the headers from the source archive but
the Version.h is generated from a template (Version.h.in) and so it is not
present in the source archive. I've added a couple of file copy commands to
make sure the file makes it into the final package.
<!-- Describe the modifications you've done. -->
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
# Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
- [x] `doc-not-needed`
The documentation already states this header will be present
- [ ] `doc`
- [ ] `doc-complete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
