poorbarcode commented on code in PR #25461:
URL: https://github.com/apache/pulsar/pull/25461#discussion_r3131578186
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java:
##########
@@ -1361,10 +1361,12 @@ public static ByteBuf newGetSchemaResponseError(long
requestId, ServerError erro
return serializeWithSize(newGetSchemaResponseErrorCommand(requestId,
error, errorMessage));
}
- public static ByteBuf newGetOrCreateSchema(long requestId, String topic,
SchemaInfo schemaInfo) {
+ public static ByteBuf newGetOrCreateSchema(long requestId, String topic,
String producerName,
+ SchemaInfo schemaInfo) {
BaseCommand cmd = localCmd(Type.GET_OR_CREATE_SCHEMA);
Schema schema = cmd.setGetOrCreateSchema()
.setRequestId(requestId)
+ .setProducerName(producerName)
Review Comment:
I will also add a test for the case then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
