Denovo1998 commented on PR #25237: URL: https://github.com/apache/pulsar/pull/25237#issuecomment-4304286164
Could we add a regression test that reproduces the original race condition? The fix depends on preserving a SessionLost event from the SessionReestablished callback path, but the existing metadata tests only cover the successful re-registration path after a reconnect. Without a test that fails addWatch during SessionReestablished and verifies the event is emitted again, this could regress easily in a future refactor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
