merlimat commented on code in PR #25568:
URL: https://github.com/apache/pulsar/pull/25568#discussion_r3125842516
##########
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java:
##########
@@ -267,6 +267,7 @@ private void downloadFile(File pkgFile, boolean
isPkgUrlProvided, FunctionMetaDa
.attr("source", downloadFromHttp ? pkgLocationPath :
pkgLocation)
.log("Function package file will be downloaded");
+ long downloadStartMs = System.currentTimeMillis();
Review Comment:
nit: this could be using:
```java
Event downloadEvent = log.info().timed();
//....
downloadEvent.attr("tenant", details.getTenant())
.attr("namespace", details.getNamespace())
.attr("functionName", details.getName())
.attr("pkgFile", tempPkgFile)
.attr("sizeBytes", tempPkgFile.length())
.log("Function package file downloaded");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
