lhotari commented on code in PR #673:
URL: https://github.com/apache/pulsar-helm-chart/pull/673#discussion_r3120451355
##########
charts/pulsar/templates/_certs.tpl:
##########
@@ -75,6 +75,10 @@ metadata:
labels:
{{- include "pulsar.standardLabels" .root | nindent 4 }}
spec:
+{{- if .tlsConfig.secretAnnotations }}
Review Comment:
please also add a `secretAnnotations` config to
`.ci/clusters/values-tls.yaml` to exercise this in CI. We don't have great
validation for all features, so it's fine to just add the annotations to let's
say `tls.proxy.secretAnnotations` in `.ci/clusters/values-tls.yaml` to validate
that it doesn't error out after adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
