lhotari commented on code in PR #25555:
URL: https://github.com/apache/pulsar/pull/25555#discussion_r3117240994
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -4978,13 +4978,11 @@ public Optional<TopicName> getShadowSourceTopic() {
return Optional.ofNullable(shadowSourceTopic);
}
- protected boolean isExceedMaximumDeliveryDelay(ByteBuf headersAndPayload) {
+ protected boolean isExceedMaximumDeliveryDelay(ByteBuf headersAndPayload,
PublishContext publishContext) {
Review Comment:
since this techincally breaks backwards compatibility for 3rd party
implementors of PersistentTopic, is it possible that some 3rd party
implementations override this method? perhaps not very likely?
(3rd party implementations are possible with
org.apache.pulsar.broker.service.TopicFactory)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
