smbecker commented on code in PR #672: URL: https://github.com/apache/pulsar-helm-chart/pull/672#discussion_r3113325214
########## charts/pulsar/templates/jwt-secret-init.yaml: ########## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# When JWT authentication is enabled and generateSecrets is true, this pre-install/pre-upgrade +# hook job generates JWT signing keys and per-subject tokens, storing them as Kubernetes secrets. +# The job is skipped entirely (not rendered) if the signing key secret already exists. +# Individual token secrets that already exist are also left untouched. +{{- if and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled .Values.auth.authentication.jwt.generateSecrets.enabled }} +{{- $ns := include "pulsar.namespace" . }} +{{- $keySecret := ternary "symmetric" "asymmetric" .Values.auth.authentication.jwt.usingSecretKey }} +{{- if not (lookup "v1" "Secret" $ns (printf "%s-token-%s-key" .Release.Name $keySecret)) }} Review Comment: Correct that `lookup` will return empty without a cluster context. However, the existing `create_secret` behavior will effectively behave the same in that if the secret exists, it will skip over it. [That behavior](https://github.com/apache/pulsar-helm-chart/pull/672#discussion_r3113302156) is intentional as we have seen issues with regenerating this secret on upgrades. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
