lhotari commented on PR #25367: URL: https://github.com/apache/pulsar/pull/25367#issuecomment-4280093496
> I think we should not depend much from the cache itself. The `TopicName` construction is low-efficient and used nearly everywhere. Could you try my previous patch here (#24463) to see if there is any improvement? If so, I can resolve the conflicts again @BewareMyPower Could you rebase #24463? I think we can handle that optimization separately. On the caching: one benefit worth preserving is that the TopicName and NamespaceName caches reduce java.lang.String instance duplication, which is valuable beyond just avoiding the construction cost itself. So I'd lean toward keeping the caches rather than removing them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
