merlimat opened a new pull request, #25545:
URL: https://github.com/apache/pulsar/pull/25545

   ### Motivation
   
   When the broker starts, the `Messaging service is ready` log entry attaches 
the entire `ServiceConfiguration` object. With hundreds of configuration 
fields, this produces pages of output on every startup — almost all of it 
matching the built-in defaults and adding noise without any diagnostic value.
   
   ### Modifications
   
   - Added 
`PulsarConfigurationLoader#runtimeConfigurationOverrides(PulsarConfiguration)` 
that returns the subset of `@FieldContext`-annotated fields whose current value 
differs from a freshly-instantiated defaults instance of the same class. Extra 
entries in `PulsarConfiguration#getProperties()` (not backed by declared 
fields) are also included.
   - Updated the `Messaging service is ready` log in `PulsarService` to attach 
`configOverrides` (the diff map) instead of the full `config` object.
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Added `PulsarConfigurationLoaderTest#testRuntimeConfigurationOverrides` 
covering overrides of `String`, `int`, `long`, `boolean`, `double`, enum, 
`Optional<Integer>`, and `Set<String>` fields, an extra non-declared 
`Properties` entry, a no-op default assignment (must not appear), and the 
empty-overrides case for a fresh configuration.
   
   ### Does this pull request potentially affect one of the following parts:
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to