merlimat opened a new pull request, #25541: URL: https://github.com/apache/pulsar/pull/25541
## Summary - Drop `libs.slf4j.api` from 15 Gradle modules that no longer use SLF4J in their source code after the PIP-467 slog conversion - Convert the last three SLF4J loggers still in `pulsar-broker/src/main` to slog (interface-level shared loggers in `SchemaDataValidator`, `SchemaRegistryService`, and an unused one in `TopicPoliciesService`) - Remove an unused `TestLogAppender.create(org.slf4j.Logger)` overload - Goal: prevent new code from inadvertently re-introducing an SLF4J logger in modules where everything is already on slog ## Modules where `slf4j.api` is kept (intentional) - `pulsar-functions/api-java`, `pulsar-functions/java-examples` — part of the public user-facing Functions API - `pulsar-functions/runtime-all` — shadow fat-jar explicitly bundles slf4j-api + log4j-slf4j2 bridge for the functions-instance runtime - `pulsar-testclient` — excludes slf4j from the zookeeper transitive and re-adds it explicitly so it stays on the runtime classpath ## Test plan - [x] `compileJava`, `compileTestJava`, `checkstyleMain`, `checkstyleTest` pass for every touched module - [x] `grep` confirms zero `org.slf4j` / `LoggerFactory` / `@Slf4j` usages in `src/main` and `src/test` of the modules that dropped the dependency - [ ] CI passes ### Motivation PIP-467 > [!NOTE] > Please label this PR with `ready-to-test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
