nodece opened a new pull request, #25525: URL: https://github.com/apache/pulsar/pull/25525
### Motivation When `ackReceiptEnabled=false`, grouped consumer acks are sent in the background and local write failures were able to drop pending ack state. That makes best-effort ack delivery weaker than expected and increases the risk of ack holes that can block progress in cases like `Key_Shared` consumption. ### Modifications - retain pending grouped acks for best-effort retry when send fails and `ackReceiptEnabled=false` - keep `ackReceiptEnabled=true` on explicit future/ack-receipt failure semantics instead of internal pending restore - add coverage for both no-receipt retry behavior and ack-receipt failure behavior - expose a small `@VisibleForTesting` accessor to avoid reflection in the tracker test - update client test fixtures to mock `ctx.write(...)` consistently ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - `./gradlew --no-daemon :pulsar-client-original:test --tests org.apache.pulsar.client.impl.AcknowledgementsGroupingTrackerTest` ### Does this pull request potentially affect one of the following parts: - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
