gosonzhang commented on PR #25501: URL: https://github.com/apache/pulsar/pull/25501#issuecomment-4222986235
> > > While normally inFlightTasks contains at most one pending read task (guaranteed by hasPendingRead() in acquirePermitsIfNotFetchingSchema()), in exceptional scenarios, multiple tasks with entries == null may occur. > > > > > > Can you provide a detailed explanation of this scenario and add a unit test to cover it? > > @liangyepianzhou Improvement to the existing implementation: if multiple tasks with `entries == null` actually appear in `inFlightTasks`, the previous implementation would inevitably cause consumption stuck. > > In reality, `inFlightTasks` should not and will not have multiple tasks with `entries == null` during runtime, so there's no way to construct this scenario. @liangyepianzhou The relevant tests for pr(https://github.com/apache/pulsar/pull/24189) have covered the modified parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
