lhotari commented on code in PR #25457:
URL: https://github.com/apache/pulsar/pull/25457#discussion_r3027636571
##########
bouncy-castle/bc/build.gradle.kts:
##########
@@ -19,6 +19,7 @@
plugins {
id("pulsar.java-conventions")
+ id("pulsar.publish-conventions")
Review Comment:
I believe that this is the recommended approach in Gradle builds. We won't
be adding new modules often, so it's possible to decide at that point whether a
module should be published or not. For example, testing related modules
shouldn't be published by default. If java-conventions publishes by default, it
will be forgotten.
For publishing, there should be an extra check that ensures that project
references in a published project are satisfied. That prevents mistakes where
resolving a dependency from maven central wouldn't be possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
