Denovo1998 commented on code in PR #25453:
URL: https://github.com/apache/pulsar/pull/25453#discussion_r3021662668
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -534,11 +532,13 @@ jobs:
with:
limit-access-to-actor: true
- - name: Set up JDK ${{ env.CI_JDK_MAJOR_VERSION }}
+ - name: Set up JDK ${{ env.CI_JDK_MAJOR_VERSION }}${{ matrix.runtime_jdk
&& matrix.runtime_jdk != env.CI_JDK_MAJOR_VERSION && format(' and {0}',
matrix.runtime_jdk) || '' }}
uses: actions/setup-java@v5
with:
distribution: ${{ env.JDK_DISTRIBUTION }}
- java-version: ${{ env.CI_JDK_MAJOR_VERSION }}
+ java-version: >-
+ ${{ matrix.runtime_jdk != env.CI_JDK_MAJOR_VERSION &&
matrix.runtime_jdk || '' }}
+ ${{ env.CI_JDK_MAJOR_VERSION }}
Review Comment:
This uses a folded scalar (`>-`) for `java-version`, but
`actions/setup-java@v5` parses multiple JDKs with `getMultilineInput` and
documents the multiline form with `|`. With `>-`, YAML folds the value into a
single string like `17 21` instead of two versions, so this step won't actually
install two JDKs. Maybe should switch this to a literal block (`|`) or use two
explicit `setup-java` steps.
##########
tiered-storage/file-system/build.gradle.kts:
##########
@@ -81,3 +81,12 @@ dependencies {
testImplementation("org.eclipse.jetty:jetty-servlet:9.4.58.v20250814")
testImplementation("org.eclipse.jetty:jetty-util:9.4.58.v20250814")
}
+
+// Hadoop 3.4.x is incompatible with Java 25
Review Comment:
This disables every test in `tiered-storage/file-system` on Java 25, but
`FileSystemOffloaderLocalFileTest` is a local-file test and does not use
`MiniDFSCluster` / the Jetty 9-based HDFS test setup. Could we narrow this skip
to the HDFS/MiniDFS-based tests instead of dropping all test coverage for the
module on Java 25?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
