lhotari commented on code in PR #25445:
URL: https://github.com/apache/pulsar/pull/25445#discussion_r3018293622
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/KeySharedSubscriptionTest.java:
##########
@@ -1218,11 +1211,7 @@ public void
testOrderingWithConsumerListener(KeySharedImplementationType impl, b
.subscriptionName(subName)
.subscriptionType(SubscriptionType.Key_Shared)
.messageListener((MessageListener<Integer>) (consumer1, msg)
-> {
- try {
- Thread.sleep(random.nextInt(5));
Review Comment:
IIRC, In this particular case, the random delay triggered the problem.
removing this will change the original intention. It's my bad that this hasn't
been properly documented initially in test code. I'd assume that the PR has
some description.
The impact to the test duration will be around 2000 ms due to this 0-4ms
random delay for 1000 messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
