merlimat opened a new pull request, #25448:
URL: https://github.com/apache/pulsar/pull/25448
## Summary
- Switch `HealthCheckTest` from `@BeforeMethod`/`@AfterMethod` to
`@BeforeClass`/`@AfterClass` so the Docker-based PulsarCluster is started once
instead of once per test method
- Add `SIGCONT` (`pkill -CONT`) in `finally` blocks for destructive tests
(`testZooKeeperDown`, `testBookKeeperDown`) to resume stopped processes and
keep the cluster usable
- Properly override `TestRetrySupport.setup()`/`cleanup()` and remove unused
imports/dead code
This reduces the test from ~5 minutes (3 full cluster start/stop cycles) to
~2 minutes (1 cycle).
### Motivation
`HealthCheckTest` was one of the slowest integration tests. Each of its 3
test methods was spinning up an entire PulsarCluster (ZooKeeper + BookKeeper +
Broker containers) and tearing it down, even though the tests themselves are
trivial healthcheck CLI calls.
### Documentation
- [ ] `doc-required`
(If you update the description, also update the determine of the
documentation)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc` (Your PR doesn't need any doc update)
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
---
- [ ] `ready-to-test`
area/test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
