This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 807d055a565 [improve][build] Fix dangling-doc-comments, fallthrough,
and section comment warnings (#25416)
807d055a565 is described below
commit 807d055a5655cb32682ff93913f4b3004f4089df
Author: Matteo Merli <[email protected]>
AuthorDate: Fri Mar 27 18:43:00 2026 -0700
[improve][build] Fix dangling-doc-comments, fallthrough, and section
comment warnings (#25416)
---
.../apache/zookeeper/server/admin/PostCommand.java | 2 +-
.../bookkeeper/mledger/impl/ManagedLedgerImpl.java | 2 +-
.../org/apache/pulsar/client/admin/Namespaces.java | 2 +-
.../org/apache/pulsar/common/nar/FileUtils.java | 2 +-
.../apache/pulsar/common/nar/NarClassLoader.java | 2 +-
.../pulsar/common/nar/NarClassLoaderBuilder.java | 2 +-
.../org/apache/pulsar/common/nar/NarUnpacker.java | 2 +-
.../apache/pulsar/common/tls/InetAddressUtils.java | 2 +-
.../pulsar/common/tls/NoopHostnameVerifier.java | 2 +-
.../apache/pulsar/common/tls/PublicSuffixList.java | 2 +-
.../pulsar/common/tls/PublicSuffixMatcher.java | 2 +-
.../org/apache/pulsar/common/tls/SubjectName.java | 2 +-
.../pulsar/common/tls/TlsHostnameVerifier.java | 2 +-
.../org/apache/pulsar/common/util/FieldParser.java | 2 +-
.../pulsar/functions/auth/FunctionAuthData.java | 6 ++---
.../pulsar/functions/runtime/RuntimeSpawner.java | 2 +-
.../runtime/thread/ThreadRuntimeFactoryConfig.java | 4 ++--
.../pulsar/functions/worker/WorkerConfig.java | 26 +++++++++++-----------
.../functions/worker/FunctionMetaDataManager.java | 2 +-
.../worker/rest/api/v2/FunctionsApiV2Resource.java | 6 ++---
.../worker/rest/api/v3/FunctionsApiV3Resource.java | 6 ++---
.../worker/rest/api/v3/SinkApiV3Resource.java | 6 ++---
.../worker/rest/api/v3/SourceApiV3Resource.java | 6 ++---
.../pulsar/io/batchdatagenerator/Person.java | 8 +++----
.../org/apache/pulsar/io/datagenerator/Person.java | 8 +++----
.../metadata/impl/MetadataStoreFactoryImpl.java | 1 +
.../apache/pulsar/proxy/server/ProxyClientCnx.java | 2 +-
.../pulsar/proxy/server/ProxyConfiguration.java | 2 +-
.../coordinator/TransactionMetadataStoreState.java | 19 ----------------
.../org/apache/bookkeeper/test/ServerTester.java | 2 +-
30 files changed, 58 insertions(+), 76 deletions(-)
diff --git
a/jetty-upgrade/zookeeper-with-patched-admin/src/main/java/org/apache/zookeeper/server/admin/PostCommand.java
b/jetty-upgrade/zookeeper-with-patched-admin/src/main/java/org/apache/zookeeper/server/admin/PostCommand.java
index 23795ed34ae..14c1f494c74 100644
---
a/jetty-upgrade/zookeeper-with-patched-admin/src/main/java/org/apache/zookeeper/server/admin/PostCommand.java
+++
b/jetty-upgrade/zookeeper-with-patched-admin/src/main/java/org/apache/zookeeper/server/admin/PostCommand.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* Command that represents HTTP POST request
*/
package org.apache.zookeeper.server.admin;
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index 0f424ec20db..744941a6438 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -3488,7 +3488,7 @@ public class ManagedLedgerImpl implements ManagedLedger,
CreateCallback {
}
}
- @SuppressWarnings("checkstyle:fallthrough")
+ @SuppressWarnings({"checkstyle:fallthrough", "fallthrough"})
private void deleteAllLedgers(DeleteLedgerCallback callback, Object ctx) {
List<LedgerInfo> ledgers =
Lists.newArrayList(ManagedLedgerImpl.this.ledgers.values());
AtomicInteger ledgersToDelete = new AtomicInteger(ledgers.size());
diff --git
a/pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
b/pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
index 50abc798e31..85a8d1d744e 100644
---
a/pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
+++
b/pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
@@ -1644,7 +1644,7 @@ public interface Namespaces {
*/
CompletableFuture<Void> removeAutoSubscriptionCreationAsync(String
namespace);
- /**
+ /*
* Get the bundles split data.
*
* @param namespace
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/FileUtils.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/FileUtils.java
index 7f313676345..38665ce4e1b 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/FileUtils.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/FileUtils.java
@@ -17,7 +17,7 @@
* under the License.
*/
-/**
+/*
* This class was adapted from NiFi NAR Utils
*
https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java
index bf94b560459..27132df1607 100644
---
a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java
+++
b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* This class was adapted from NiFi NAR Utils
*
https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoaderBuilder.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoaderBuilder.java
index 952c65bb2e0..e44bce87b4c 100644
---
a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoaderBuilder.java
+++
b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoaderBuilder.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* This class was adapted from NiFi NAR Utils
*
https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java
index ef802674b42..9be9a98b9e8 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* This class was adapted from NiFi NAR Utils
*
https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/InetAddressUtils.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/InetAddressUtils.java
index d0f3c81a074..58c5f7831bf 100644
---
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/InetAddressUtils.java
+++
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/InetAddressUtils.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* From Apache HTTP client
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/NoopHostnameVerifier.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/NoopHostnameVerifier.java
index bbe725d8994..b55a6b4e320 100644
---
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/NoopHostnameVerifier.java
+++
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/NoopHostnameVerifier.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* From Apache HTTP client
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixList.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixList.java
index a2234192f8f..9cab12ef722 100644
---
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixList.java
+++
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixList.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* From Apache HTTP client
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixMatcher.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixMatcher.java
index 4ebc5aa48a9..54fd20e6e02 100644
---
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixMatcher.java
+++
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/PublicSuffixMatcher.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* From Apache HTTP client
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/SubjectName.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/SubjectName.java
index 67890bca3e4..59a7860f163 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/SubjectName.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/SubjectName.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* From Apache HTTP client
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java
index 93fba9a557d..9cec96fe1a4 100644
---
a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java
+++
b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* From Apache HTTP client
*/
diff --git
a/pulsar-common/src/main/java/org/apache/pulsar/common/util/FieldParser.java
b/pulsar-common/src/main/java/org/apache/pulsar/common/util/FieldParser.java
index 55863b08cff..4aa3048c137 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/util/FieldParser.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/util/FieldParser.java
@@ -246,7 +246,7 @@ public final class FieldParser {
WRAPPER_TYPES.put(boolean.class, Boolean.class);
}
- /***** --- Converters --- ****/
+ // --- Converters ---
/**
* Converts String to Integer.
diff --git
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthData.java
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthData.java
index 149d05e5196..36a5589acd2 100644
---
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthData.java
+++
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthData.java
@@ -21,11 +21,11 @@ package org.apache.pulsar.functions.auth;
import lombok.Builder;
import lombok.Data;
-@Data
-@Builder
/**
- * A wrapper for authentication data for functions
+ * A wrapper for authentication data for functions.
*/
+@Data
+@Builder
public class FunctionAuthData {
/**
* function authentication related data that the function authentication
provider
diff --git
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
index 1dc15bbc61c..4ce4c2638b0 100644
---
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
+++
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* RuntimeSpawner is the module responsible for running one particular
instance servicing one
* function. It is responsible for starting/stopping the instance and passing
data to the
* instance and getting the results back.
diff --git
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntimeFactoryConfig.java
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntimeFactoryConfig.java
index b31142f4b57..a2586d40026 100644
---
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntimeFactoryConfig.java
+++
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntimeFactoryConfig.java
@@ -26,12 +26,12 @@ import org.apache.pulsar.common.configuration.FieldContext;
@Accessors(chain = true)
public class ThreadRuntimeFactoryConfig {
- @Data
- @Accessors(chain = true)
/**
* Memory limit set for the pulsar client used by all instances
* If `absoluteValue` and `percentOfMaxDirectMemory` are both set, then
the min of the two will be used.
*/
+ @Data
+ @Accessors(chain = true)
public static class MemoryLimit {
@FieldContext(
doc = "The max memory in bytes the pulsar client can use"
diff --git
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
index 060d9831082..8a97ee077a0 100644
---
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
+++
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
@@ -907,15 +907,15 @@ public class WorkerConfig implements Serializable,
PulsarConfiguration {
this.properties = properties;
}
- /********* DEPRECATED CONFIGS. *********/
+ // --------- DEPRECATED CONFIGS ---------
- @Deprecated
- @Data
- @EqualsAndHashCode(callSuper = false)
/**
- * @Deprecated in favor for using functionRuntimeFactoryClassName and
functionRuntimeFactoryConfigs
+ * @deprecated in favor for using functionRuntimeFactoryClassName and
functionRuntimeFactoryConfigs
* for specifying the function runtime and configs to use
*/
+ @Deprecated
+ @Data
+ @EqualsAndHashCode(callSuper = false)
public static class ThreadContainerFactory extends
ThreadRuntimeFactoryConfig {
}
@@ -926,13 +926,13 @@ public class WorkerConfig implements Serializable,
PulsarConfiguration {
@Deprecated
private ThreadContainerFactory threadContainerFactory;
- @Deprecated
- @Data
- @EqualsAndHashCode(callSuper = false)
/**
- * @Deprecated in favor for using functionRuntimeFactoryClassName and
functionRuntimeFactoryConfigs
+ * @deprecated in favor for using functionRuntimeFactoryClassName and
functionRuntimeFactoryConfigs
* for specifying the function runtime and configs to use
*/
+ @Deprecated
+ @Data
+ @EqualsAndHashCode(callSuper = false)
public static class ProcessContainerFactory extends
ProcessRuntimeFactoryConfig {
}
@@ -943,13 +943,13 @@ public class WorkerConfig implements Serializable,
PulsarConfiguration {
@Deprecated
private ProcessContainerFactory processContainerFactory;
- @Deprecated
- @Data
- @EqualsAndHashCode(callSuper = false)
/**
- * @Deprecated in favor for using functionRuntimeFactoryClassName and
functionRuntimeFactoryConfigs
+ * @deprecated in favor for using functionRuntimeFactoryClassName and
functionRuntimeFactoryConfigs
* for specifying the function runtime and configs to use
*/
+ @Deprecated
+ @Data
+ @EqualsAndHashCode(callSuper = false)
public static class KubernetesContainerFactory extends
KubernetesRuntimeFactoryConfig {
}
diff --git
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
index 944b4e8e344..3a5f10aa4bb 100644
---
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
+++
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
@@ -92,7 +92,7 @@ public class FunctionMetaDataManager implements AutoCloseable
{
exclusiveLeaderProducer = null;
}
- /**
+ /*
* Public methods. Please use these methods if references
FunctionMetaManager from an external class
*/
diff --git
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionsApiV2Resource.java
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionsApiV2Resource.java
index 0b125756b30..e8a6910e070 100644
---
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionsApiV2Resource.java
+++
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionsApiV2Resource.java
@@ -308,6 +308,9 @@ public class FunctionsApiV2Resource extends
FunctionApiResource {
return functions().downloadFunction(path, authParams());
}
+ /**
+ * Deprecated in favor of moving endpoint to {@link
org.apache.pulsar.broker.admin.v2.Worker}.
+ */
@GET
@ApiOperation(
value = "Fetches a list of supported Pulsar IO connectors
currently running in cluster mode",
@@ -319,9 +322,6 @@ public class FunctionsApiV2Resource extends
FunctionApiResource {
@ApiResponse(code = 408, message = "Request timeout")
})
@Path("/connectors")
- /**
- * Deprecated in favor of moving endpoint to {@link
org.apache.pulsar.broker.admin.v2.Worker}
- */
@Deprecated
public List<ConnectorDefinition> getConnectorsList() throws IOException {
return functions().getListOfConnectors();
diff --git
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionsApiV3Resource.java
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionsApiV3Resource.java
index 7bdc86d5fae..af03f2176d1 100644
---
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionsApiV3Resource.java
+++
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionsApiV3Resource.java
@@ -347,11 +347,11 @@ public class FunctionsApiV3Resource extends
FunctionApiResource {
.downloadFunction(tenant, namespace, functionName,
authParams(), transformFunction);
}
- @GET
- @Path("/connectors")
/**
- * Deprecated in favor of moving endpoint to {@link
org.apache.pulsar.broker.admin.v2.Worker}
+ * Deprecated in favor of moving endpoint to {@link
org.apache.pulsar.broker.admin.v2.Worker}.
*/
+ @GET
+ @Path("/connectors")
@Deprecated
public List<ConnectorDefinition> getConnectorsList() throws IOException {
return functions().getListOfConnectors();
diff --git
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SinkApiV3Resource.java
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SinkApiV3Resource.java
index 4f91208f143..e1032a9bbb8 100644
---
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SinkApiV3Resource.java
+++
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SinkApiV3Resource.java
@@ -24,13 +24,13 @@ import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.MediaType;
+/**
+ * @deprecated in favor of {@link SinksApiV3Resource}
+ */
@Api(value = "/sink", description = "Sink admin apis", tags = "sink")
@Produces(MediaType.APPLICATION_JSON)
@Consumes(MediaType.APPLICATION_JSON)
@Path("/sink")
@Deprecated
-/**
- * @deprecated in favor of {@link SinksApiV3Resource}
- */
public class SinkApiV3Resource extends SinksApiV3Resource {
}
diff --git
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SourceApiV3Resource.java
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SourceApiV3Resource.java
index 47c7c5aad6f..c1c1a8c4173 100644
---
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SourceApiV3Resource.java
+++
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SourceApiV3Resource.java
@@ -24,13 +24,13 @@ import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.MediaType;
+/**
+ * @deprecated in favor of {@link SourcesApiV3Resource}
+ */
@Path("/source")
@Api(value = "/source", description = "Source admin apis", tags = "source")
@Produces(MediaType.APPLICATION_JSON)
@Consumes(MediaType.APPLICATION_JSON)
@Deprecated
-/**
- * @deprecated in favor of {@link SourcesApiV3Resource}
- */
public class SourceApiV3Resource extends SourcesApiV3Resource {
}
diff --git
a/pulsar-io/batch-data-generator/src/main/java/org/apache/pulsar/io/batchdatagenerator/Person.java
b/pulsar-io/batch-data-generator/src/main/java/org/apache/pulsar/io/batchdatagenerator/Person.java
index 43339faf41d..b91bd0051f2 100644
---
a/pulsar-io/batch-data-generator/src/main/java/org/apache/pulsar/io/batchdatagenerator/Person.java
+++
b/pulsar-io/batch-data-generator/src/main/java/org/apache/pulsar/io/batchdatagenerator/Person.java
@@ -22,14 +22,14 @@ import lombok.AllArgsConstructor;
import lombok.Data;
import lombok.NoArgsConstructor;
-@Data
-@AllArgsConstructor
-@NoArgsConstructor
/**
- * This class serves as a copy of of io.codearte.jfairy.producer.person.Person
+ * This class serves as a copy of io.codearte.jfairy.producer.person.Person.
* because io.codearte.jfairy.producer.person.Person does not
* have default constructors needed to deserialize POJOs
*/
+@Data
+@AllArgsConstructor
+@NoArgsConstructor
public class Person {
private Address address;
private String firstName;
diff --git
a/pulsar-io/data-generator/src/main/java/org/apache/pulsar/io/datagenerator/Person.java
b/pulsar-io/data-generator/src/main/java/org/apache/pulsar/io/datagenerator/Person.java
index a5bf2abb54c..c6a1a785c5e 100644
---
a/pulsar-io/data-generator/src/main/java/org/apache/pulsar/io/datagenerator/Person.java
+++
b/pulsar-io/data-generator/src/main/java/org/apache/pulsar/io/datagenerator/Person.java
@@ -22,14 +22,14 @@ import lombok.AllArgsConstructor;
import lombok.Data;
import lombok.NoArgsConstructor;
-@Data
-@AllArgsConstructor
-@NoArgsConstructor
/**
- * This class serves as a copy of of io.codearte.jfairy.producer.person.Person
+ * This class serves as a copy of io.codearte.jfairy.producer.person.Person.
* because io.codearte.jfairy.producer.person.Person does not
* have default constructors needed to deserialize POJOs
*/
+@Data
+@AllArgsConstructor
+@NoArgsConstructor
public class Person {
private Address address;
private String firstName;
diff --git
a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java
b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java
index 33e6d861d3d..65a12117a73 100644
---
a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java
+++
b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java
@@ -62,6 +62,7 @@ public class MetadataStoreFactoryImpl {
return provider.create(metadataURL, metadataStoreConfig,
enableSessionWatcher);
}
+ @SuppressWarnings("auxiliaryclass")
static Map<String, MetadataStoreProvider> loadProviders() {
Map<String, MetadataStoreProvider> providers = new HashMap<>();
providers.put(MEMORY_SCHEME_IDENTIFIER, new
MemoryMetadataStoreProvider());
diff --git
a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java
b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java
index 1e8e2fb55e4..0ad44bb0bf0 100644
---
a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java
+++
b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java
@@ -32,13 +32,13 @@ import
org.apache.pulsar.common.api.proto.CommandAuthChallenge;
import org.apache.pulsar.common.protocol.Commands;
import org.apache.pulsar.common.util.netty.NettyChannelUtil;
-@Slf4j
/**
* Channel handler for Pulsar proxy's Pulsar broker client connections for
lookup requests.
* <p>
* Please see {@link org.apache.pulsar.common.protocol.PulsarDecoder} javadoc
for important details about handle*
* method parameter instance lifecycle.
*/
+@Slf4j
public class ProxyClientCnx extends ClientCnx {
private final boolean forwardClientAuthData;
private final String clientAuthMethod;
diff --git
a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
index d55be358188..830f65bc80b 100644
---
a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
+++
b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
@@ -936,7 +936,7 @@ public class ProxyConfiguration implements
PulsarConfiguration {
}
)
- /***** --- Protocol Handlers --- ****/
+ // --- Protocol Handlers ---
@FieldContext(
category = CATEGORY_PLUGIN,
doc = "The directory to locate proxy extensions"
diff --git
a/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionMetadataStoreState.java
b/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionMetadataStoreState.java
index 913f412d9b8..c0f1241e462 100644
---
a/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionMetadataStoreState.java
+++
b/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionMetadataStoreState.java
@@ -16,25 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
package org.apache.pulsar.transaction.coordinator;
import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
diff --git
a/testmocks/src/main/java/org/apache/bookkeeper/test/ServerTester.java
b/testmocks/src/main/java/org/apache/bookkeeper/test/ServerTester.java
index f519394d092..a808123a86f 100644
--- a/testmocks/src/main/java/org/apache/bookkeeper/test/ServerTester.java
+++ b/testmocks/src/main/java/org/apache/bookkeeper/test/ServerTester.java
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/**
+/*
* This file is derived from BookKeeperClusterTestCase from Apache BookKeeper
* http://bookkeeper.apache.org
*/
