lhotari commented on code in PR #25372:
URL: https://github.com/apache/pulsar/pull/25372#discussion_r2976191334
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -996,25 +996,25 @@ jobs:
- name: Check binary licenses
run: src/check-binary-license.sh
./distribution/server/target/apache-pulsar-*-bin.tar.gz &&
src/check-binary-license.sh
./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
-# - name: Run Trivy container scan
-# id: trivy_scan
-# uses: aquasecurity/[email protected]
-# if: ${{ github.repository == 'apache/pulsar' && github.event_name !=
'pull_request' }}
-# continue-on-error: true
-# with:
-# image-ref: "apachepulsar/pulsar:latest"
-# scanners: vuln
-# severity: CRITICAL,HIGH,MEDIUM,LOW
-# limit-severities-for-sarif: true
-# format: 'sarif'
-# output: 'trivy-results.sarif'
-#
-# - name: Upload Trivy scan results to GitHub Security tab
-# uses: github/codeql-action/upload-sarif@v3
-# if: ${{ steps.trivy_scan.outcome == 'success' && github.repository ==
'apache/pulsar' && github.event_name != 'pull_request' }}
-# continue-on-error: true
-# with:
-# sarif_file: 'trivy-results.sarif'
+ - name: Run Trivy container scan
+ id: trivy_scan
+ uses: aquasecurity/[email protected]
Review Comment:
ASF policy requires pinning to a hash.
```suggestion
uses:
aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1
```
This won't work until the action & hash is included in
https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
