merlimat opened a new pull request, #25378:
URL: https://github.com/apache/pulsar/pull/25378
## Flaky test failure
```
org.awaitility.core.ConditionTimeoutException: Assertion condition expected
[true] but found [false] within 10 seconds.
at
org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer(ExtensibleLoadManagerImplTest.java:1324)
```
## Summary
- Fix flaky
`ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer` by
making it deterministic instead of time-dependent.
- The test updates the `loadBalancerServiceUnitTableViewSyncer` dynamic
config and immediately triggers leader transitions. If the config hasn't
propagated to the broker's `ServiceConfiguration` by the time the leader
callback fires, `isLoadBalancerServiceUnitTableViewSyncerEnabled()` returns
false and the syncer is never activated — causing the 10s Awaitility timeout to
expire.
- Fix by explicitly waiting for the dynamic config to propagate to both
brokers (by polling `isLoadBalancerServiceUnitTableViewSyncerEnabled()`) before
triggering leader transitions. This ensures the leader callback sees the
updated config and activates the syncer deterministically.
- Apply the same pattern to the cleanup section where the config is deleted.
## Documentation
- [x] `doc-not-needed`
(Your PR doesn't need any doc update)
## Matching PR in forked repository
_No response_
### Tip
Add the labels `ready-to-test` and `area/test` to trigger the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
