merlimat opened a new pull request, #25358:
URL: https://github.com/apache/pulsar/pull/25358

   ## Flaky test failure
   
   ```
   ReplicatorTest.testResumptionAfterBacklogRelaxed[producer_exception](4):
   Expecting actual:
     0.0
   to be greater than:
     0.0
        at 
ReplicatorTest.testResumptionAfterBacklogRelaxed(ReplicatorTest.java:1049)
   ```
   
   ## Summary
   
   - Fix flaky `ReplicatorTest.testResumptionAfterBacklogRelaxed` which asserts 
`pulsar.broker.replication.message.backlog.age` is strictly positive when there 
is a replication backlog.
   - `AbstractReplicator.getReplicationDelayMs()` returns `0` when the 
replicator's producer is `null`, which happens when replication is paused due 
to backlog quota being exceeded. The metric is derived from this value, so it 
can legitimately be `0.0` even with a non-empty backlog.
   - Change the assertion from `isPositive()` to `isGreaterThanOrEqualTo(0.0)`.
   
   ## Documentation
   
   - [x] `doc-not-needed`
   (Your PR doesn't need any doc update)
   
   ## Matching PR in forked repository
   
   _No response_
   
   ### Tip
   
   Add the labels `ready-to-test` and `area/test` to trigger the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to