jasperjiaguo commented on code in PR #14910:
URL: https://github.com/apache/pinot/pull/14910#discussion_r1932979540
##########
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitionsUtils.java:
##########
@@ -59,13 +59,13 @@ public static String getInstancePartitionsName(String
tableName, String instance
/**
* Fetches the instance partitions from Helix property store if it exists,
or computes it for backward-compatibility.
*/
- public static InstancePartitions
fetchOrComputeInstancePartitions(HelixManager helixManager, TableConfig
tableConfig,
- InstancePartitionsType instancePartitionsType) {
+ public static InstancePartitions
fetchOrComputeInstancePartitionsForSegmentAssignment(HelixManager helixManager,
Review Comment:
I think it's fine to keep the name and not deprecating anything. This code
essentially shares similar logic with instance assignment tho I think we should
merge them in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
