Jackie-Jiang commented on code in PR #14921: URL: https://github.com/apache/pinot/pull/14921#discussion_r1931323958
########## pinot-core/src/main/java/org/apache/pinot/core/routing/ServerRouteInfo.java: ########## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.routing; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import java.util.List; + +/** + * Class representing the route information for a server. + * It contains the list of segments and optional segments assigned to the server. + */ +public class ServerRouteInfo { + private final List<String> _segmentList; + private final List<String> _optionalSegmentList; + + /** + * Constructor for ServerRouteInfo. + * + * @param segmentList List of segments assigned to the server. + * @param optionalSegmentList List of optional segments assigned to the server. + */ + @JsonCreator Review Comment: Do we need to ser/de this class? ########## pinot-core/src/main/java/org/apache/pinot/core/routing/ServerRouteInfo.java: ########## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.routing; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import java.util.List; + +/** + * Class representing the route information for a server. + * It contains the list of segments and optional segments assigned to the server. + */ +public class ServerRouteInfo { + private final List<String> _segmentList; + private final List<String> _optionalSegmentList; Review Comment: (optional) More concise ```suggestion private final List<String> _segments; private final List<String> _optionalSegments; ``` ########## pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java: ########## @@ -635,15 +636,15 @@ public RoutingTable getRoutingTable(BrokerRequest brokerRequest, long requestId) selectionResult.getUnavailableSegments(), selectionResult.getNumPrunedSegments()); } - private Map<ServerInstance, Pair<List<String>, List<String>>> getServerInstanceToSegmentsMap(String tableNameWithType, + private Map<ServerInstance, ServerRouteInfo> getServerInstanceToSegmentsMap(String tableNameWithType, InstanceSelector.SelectionResult selectionResult) { - Map<ServerInstance, Pair<List<String>, List<String>>> merged = new HashMap<>(); + Map<ServerInstance, ServerRouteInfo> merged = new HashMap<>(); for (Map.Entry<String, String> entry : selectionResult.getSegmentToInstanceMap().entrySet()) { ServerInstance serverInstance = _enabledServerInstanceMap.get(entry.getValue()); if (serverInstance != null) { - Pair<List<String>, List<String>> pair = - merged.computeIfAbsent(serverInstance, k -> Pair.of(new ArrayList<>(), new ArrayList<>())); - pair.getLeft().add(entry.getKey()); + ServerRouteInfo executionInfo = Review Comment: Rename it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
