davecromberge commented on code in PR #14856:
URL: https://github.com/apache/pinot/pull/14856#discussion_r1924237325
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MergeTaskUtils.java:
##########
@@ -137,28 +137,6 @@ public static Map<String, AggregationFunctionType>
getAggregationTypes(Map<Strin
return aggregationTypes;
}
- /**
- * Returns a map from column name to the aggregation function parameters
associated with it based on the task config.
- */
- public static Map<String, Map<String, String>>
getAggregationFunctionParameters(Map<String, String> taskConfig) {
- Map<String, Map<String, String>> aggregationFunctionParameters = new
HashMap<>();
- String prefix = MergeTask.AGGREGATION_FUNCTION_PARAMETERS_PREFIX;
-
- for (Map.Entry<String, String> entry : taskConfig.entrySet()) {
- String key = entry.getKey();
- String value = entry.getValue();
- if (key.startsWith(prefix)) {
- String[] parts = key.substring(prefix.length()).split("\\.", 2);
- if (parts.length == 2) {
- String metricColumn = parts[0];
- String paramName = parts[1];
- aggregationFunctionParameters.computeIfAbsent(metricColumn, k -> new
HashMap<>()).put(paramName, value);
- }
- }
- }
- return aggregationFunctionParameters;
- }
-
Review Comment:
This has been moved to the `MergeRollupTaskUtils` helper because it is
unique to MergeRollup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
