DaniilRoman commented on issue #14051: URL: https://github.com/apache/pinot/issues/14051#issuecomment-2601025853
Hey there 👋 I'm looking for an issue to tackle but before diving into this one I'd like to clarify if I understand it correctly. The change is needed for this class [ControllerPeriodicTask](https://github.com/DaniilRoman/pinot/blob/00b5a73b20415aaea0f9bb4f44c07ad21f563193/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java#L47), right? 1. I see that when we initiate a controller periodic task we use [ControllerConf](https://github.com/DaniilRoman/pinot/blob/6eddacfc32055e959ad72634684b904cf4098e20/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java#L44) and pass a [STATUS_CHECKER_INITIAL_DELAY_IN_SECONDS](https://github.com/DaniilRoman/pinot/blob/6eddacfc32055e959ad72634684b904cf4098e20/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java#L989). 2. The idea is to create an additional field in ControllerConf for a CRON configuration and parse it into `STATUS_CHECKER_INITIAL_DELAY_IN_SECONDS`, right? 3. Would you suggest using an external library to parse CRON expression, like this one https://github.com/jmrozanec/cron-utils, or implementing the parsing manually? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
