Jackie-Jiang commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1915935274
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/Constants.java:
##########
@@ -33,4 +33,5 @@ private Constants() {
public static final String THETA_TUPLE_SKETCH_SAMPLING_PROBABILITY =
"samplingProbability";
public static final String PERCENTILETDIGEST_COMPRESSION_FACTOR_KEY =
"compressionFactor";
public static final String SUMPRECISION_PRECISION_KEY = "precision";
+ public static final String KLL_DOUBLE_SKETCH_K = "K";
Review Comment:
Do we want to make this capital `K`? Also calling it `DOUBLE_SKETCH_K` is a
little bit confusing because it is actually an `int`.
If we follow the same format as `HLL`, it should be `KLL_SKETCH_K_KEY = "k"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
