itschrispeck commented on PR #14765: URL: https://github.com/apache/pinot/pull/14765#issuecomment-2591317250
> While in most cases, there is only one topic per table (single-stream ingestion). I don't want to make size based threshold updater to be per topic by default. It will cause backward incompatibility for metrics as well. Another drawback is slower converge time for segment size. If you can make this only apply to multi-stream ingestion, I'm okay with that. But again, suggest making it configurable To clarify, the ask here would be to have a table based ctor and table+topic based ctor? and then use the latter for multi-stream ingestion only or if enabled? re: size convergence time, I feel that making the currently hardcoded weights/multipliers configurable would be a more robust way of optimizing for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
