gortiz commented on code in PR #14345: URL: https://github.com/apache/pinot/pull/14345#discussion_r1910167423
########## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/nativefst/ImmutableFSTDeserializedTest.java: ########## @@ -41,6 +44,14 @@ public void setUp() } } + @AfterClass + public void tearDown() + throws IOException { + if (_fst instanceof ImmutableFST) { + ((ImmutableFST) _fst)._mutableBytesStore.close(); Review Comment: That method is only called in tests. Probably we should remove/refactor it. Anyway, just keep it as it is in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org