Jackie-Jiang commented on code in PR #14772:
URL: https://github.com/apache/pinot/pull/14772#discussion_r1909871219
##########
pinot-spi/src/test/java/org/apache/pinot/spi/config/table/IndexingConfigTest.java:
##########
@@ -103,21 +103,15 @@ public void testSegmentPartitionConfig()
@Test
public void testOptimizeDictionaryConfigs()
throws JsonProcessingException {
- String indexingConfigStr = "{"
- + "\"optimizeDictionary\": true,"
- + "\"optimizeDictionaryForMetrics\": true,"
- + "\"noDictionarySizeRatioThreshold\": 0.50"
- + "}";
+ String indexingConfigStr = "{" + "\"optimizeDictionary\": true," +
"\"optimizeDictionaryForMetrics\": true,"
Review Comment:
(minor) Should we revert the changes in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
