Jackie-Jiang commented on code in PR #14684:
URL: https://github.com/apache/pinot/pull/14684#discussion_r1898182078
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/DedupConfig.java:
##########
@@ -96,4 +96,10 @@ public String getDedupTimeColumn() {
public boolean isEnablePreload() {
return _enablePreload;
}
+
+ // CHECKSTYLE:OFF
Review Comment:
I know why it doesn't like it. This method should not return anything.
Change the return to `void` should be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
