ankitsultana commented on code in PR #14582:
URL: https://github.com/apache/pinot/pull/14582#discussion_r1869956678
##########
pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/plan/TransformNullPlanNode.java:
##########
@@ -34,15 +34,20 @@ public class TransformNullPlanNode extends
BaseTimeSeriesPlanNode {
@JsonCreator
public TransformNullPlanNode(@JsonProperty("id") String id,
@JsonProperty("defaultValue") Double defaultValue,
- @JsonProperty("children") List<BaseTimeSeriesPlanNode> children) {
- super(id, children);
+ @JsonProperty("inputs") List<BaseTimeSeriesPlanNode> inputs) {
Review Comment:
It is to be consistent with pinot-query-planner PlanNode, which is what we
want to coalesce with in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
