lnbest0707-uber commented on PR #14546: URL: https://github.com/apache/pinot/pull/14546#issuecomment-2515681588
> Since this one is already backward incompatible, and we want to remove v1 (I assume it is not in use), should we consider directly removing v1 and remove the v2 suffix? We should try to avoid the overhead of maintaining both of them Thanks for bringing this up @Jackie-Jiang . Those are valid concerns. We will remove the v1 transformer in the next PR. For removing V2 from the naming, that's the correct direction we should follow. However, from our production running POV, that requires a dedicated migration story to change the config on existing tables. We are targeting to complete it in 2025 Q1. We could propose that, in next diff: - Remove V1 transformer - Create a transformer without V2 tag whose code is exactly same as V2 - Mark V2 as deprecated The removal of V2 would be later next year after we complete the migration. Does this sound reasonable? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
