Jackie-Jiang commented on code in PR #14547:
URL: https://github.com/apache/pinot/pull/14547#discussion_r1861117053
##########
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordExtractor.java:
##########
@@ -40,9 +38,9 @@ public class JSONRecordExtractor extends
BaseRecordExtractor<Map<String, Object>
public void init(Set<String> fields, @Nullable RecordExtractorConfig
recordExtractorConfig) {
if (fields == null || fields.isEmpty()) {
_extractAll = true;
- _fields = Collections.emptySet();
+ _fields = Set.of();
Review Comment:
They are the same (both using constant empty set). Java 9 moved several
common utils into `Set`/`Map`, which are quite handy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
