mqliang opened a new pull request, #14536: URL: https://github.com/apache/pinot/pull/14536
ref: https://github.com/apache/pinot/issues/14538 This PR fix enhance SegmentStatusChecker in two scenarios: 1) If user has instance assignment config, a user may make offline segments and consuming segments may have different replica groups (e.g. use more replicas for consuming segments, but less replicas for online segments). In this situation, when calculate `PERCENT_OF_REPLICAS `, it's problematic to use global `maxISReplicas` as denominator and global `minEVReplicas` as nominator. For example, if user config replica groups for immutable segments as 3, and 5 for mutable segments, `PERCENT_OF_REPLICAS` will always be 60% even if all replicas are up, which will cause some false negative alerts. This PR change the logic to calculate EVReplicasUpPercent for each segment then emit the minimal percentage. 2) When a sever is configured as `queriesDisabled` or `shutdownInProgress`, broker does not send queries to the server. We need technically treat those replicas that on the no-queryable server as "OFFLINE" even if it shows "ONLINE" in helix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
