itschrispeck commented on code in PR #14444:
URL: https://github.com/apache/pinot/pull/14444#discussion_r1852893839
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -553,9 +553,8 @@ void collectStatsAndIndexCreationInfo()
ColumnStatistics columnProfile =
_segmentStats.getColumnProfileFor(column);
DictionaryIndexConfig dictionaryIndexConfig =
indexConfigsMap.get(column).getConfig(StandardIndexes.dictionary());
boolean createDictionary = dictionaryIndexConfig.isDisabled();
- boolean useVarLengthDictionary =
- dictionaryIndexConfig.getUseVarLengthDictionary() ||
DictionaryIndexType.shouldUseVarLengthDictionary(
- storedType, columnProfile);
+ boolean useVarLengthDictionary =
dictionaryIndexConfig.getUseVarLengthDictionary()
+ ||
DictionaryIndexType.optimizeTypeShouldUseVarLengthDictionary(storedType,
columnProfile);
Review Comment:
Good question - it won't, since this value `useVarLengthDictionary` is
currently set but unused. Only when the new config is set to true, it will be
used (false by default)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
