Jackie-Jiang commented on code in PR #14511:
URL: https://github.com/apache/pinot/pull/14511#discussion_r1852664946
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -392,6 +392,9 @@ private void validateSchemaName(Schema schema) {
throw new ControllerApplicationException(LOGGER,
"Invalid schema. Reason: 'schemaName' should not be null or empty",
Response.Status.BAD_REQUEST);
}
+ if
(schema.getSchemaName().contains(TableConfig.TABLE_NAME_FORBIDDEN_SUBSTRING)) {
+ throw new IllegalStateException("'schemaName' cannot contain double
underscore ('__')");
Review Comment:
Sorry merged it pre-maturely. Can you change this to a
`ControllerApplicationException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
