gortiz commented on code in PR #14495: URL: https://github.com/apache/pinot/pull/14495#discussion_r1852342867
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/MailboxReceiveNode.java: ########## @@ -57,6 +57,8 @@ public MailboxReceiveNode(int stageId, DataSchema dataSchema, int senderStageId, } public int getSenderStageId() { + assert _sender == null || _sender.getStageId() == _senderStageId Review Comment: I may be wrong, but in `setSender` there is now way this may fail (given we set both). This is just more a reminder of the invariant for readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org