mayankshriv commented on code in PR #14474:
URL: https://github.com/apache/pinot/pull/14474#discussion_r1849392444
##########
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java:
##########
@@ -501,12 +504,14 @@ public long length(URI fileUri)
public String[] listFiles(URI fileUri, boolean recursive)
throws IOException {
ImmutableList.Builder<String> builder = ImmutableList.builder();
+ String scheme = fileUri.getScheme();
+ Preconditions.checkArgument(scheme.equals(S3_SCHEME) ||
scheme.equals(S3A_SCHEME));
visitFiles(fileUri, recursive, s3Object -> {
if (!s3Object.key().equals(fileUri.getPath()) &&
!s3Object.key().endsWith(DELIMITER)) {
- builder.add(S3_SCHEME + fileUri.getHost() + DELIMITER +
getNormalizedFileKey(s3Object));
+ builder.add(scheme + SCHEME_SEPARATOR + fileUri.getHost() + DELIMITER
+ getNormalizedFileKey(s3Object));
Review Comment:
Naive question, is the only change needed is to pass in the write scheme
string, and everything else is compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
