gortiz commented on PR #14448: URL: https://github.com/apache/pinot/pull/14448#issuecomment-2485790031
Probably AggregateProjectConstantToDummyJoinRule, but I don't know if we support that dummy table and/or the impact it may have. Probably the introduced join may be more expensive than the current plan, but we should be able to optimize that kind of join On Tue, Nov 19, 2024 at 1:15 PM Yash Mayya ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json > <https://github.com/apache/pinot/pull/14448#discussion_r1848157142>: > > > + "description": "AND filter on constants is simplified", > + "sql": "EXPLAIN PLAN FOR WITH CTE_B AS (SELECT 1692057600000 AS __ts FROM a GROUP BY __ts) SELECT 1692057600000 AS __ts FROM CTE_B WHERE __ts >= 1692057600000 AND __ts < 1693267200000 GROUP BY __ts", > + "output": [ > + "Execution Plan", > + "\nLogicalProject(__ts=[1692057600000:BIGINT])", > + "\n PinotLogicalAggregate(group=[{0}])", > + "\n PinotLogicalExchange(distribution=[hash[0]])", > + "\n PinotLogicalAggregate(group=[{0}])", > + "\n LogicalProject(__ts=[1692057600000:BIGINT])", > + "\n LogicalTableScan(table=[[default, a]])", > + "\n" > + ] > > I'm not sure if there exists any standard rule that can optimize / reduce > this, we might need to add a custom rule for cases like this? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/pinot/pull/14448#discussion_r1848157142>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAOTJCPS4GIDDNFB5NJS7SL2BMTWZAVCNFSM6AAAAABRYKMDCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBVGEZTSOJWGQ> > . > You are receiving this because you modified the open/close state.Message > ID: ***@***.***> > -- [image: StarTree] <https://startree.ai> Gonzalo Ortiz Performance Engineer (he/him) Follow us: [image: RSS] <https://www.startree.ai/blogs>[image: LinkedIn] <https://www.linkedin.com/company/startreedata/>[image: Twitter] <https://twitter.com/startreedata>[image: Slack] <https://stree.ai/slack> [image: Save a seat at Real-Time Analytics Summit SF] <http://rtasummit.com> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
