9aman commented on code in PR #14460:
URL: https://github.com/apache/pinot/pull/14460#discussion_r1843179831
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -816,6 +816,27 @@ public void run() {
// CONSUMING -> ONLINE state transition.
segmentLock.lockInterruptibly();
try {
+ // TODO(akkhanch): this has been added here as we want to
create a new consuming segment for the
+ // partition
+ // With the new commit protocol we might not need this as the
segment consumed itself will take care
+ // of the next segment commit start
+ // TODO (akkhanch): keep this after the lock has been acquired
as we don't want the state transition
+ // to impact this build. The state transition from CONSUMING
-> ONLINE will also try to acquire lock
+ // impacting this build and ingestions
+
+ // TODO: might need to support the two ways in which stream
config can be set. On under the ingestion
+ // config and other under the tableIndexConfig
+ if (isPauselessEnabeld()) {
Review Comment:
We want to Initiate the COMMIT_START before building the segment. This is
crucial for allowing ingestion while the current segment is being built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
