deemoliu commented on code in PR #14366: URL: https://github.com/apache/pinot/pull/14366#discussion_r1842871884
########## pinot-plugins/pinot-input-format/pinot-clp-log/src/main/java/org/apache/pinot/plugin/inputformat/clplog/CLPLogMessageDecoder.java: ########## @@ -38,18 +38,27 @@ * details. The implementation is based on {@link org.apache.pinot.plugin.inputformat.json.JSONMessageDecoder}. */ public class CLPLogMessageDecoder implements StreamMessageDecoder<byte[]> { + public static final String ERROR_SAMPLING_PERIOD_CONFIG_KEY = "errorSamplingPeriod"; private static final Logger LOGGER = LoggerFactory.getLogger(CLPLogMessageDecoder.class); + private static final int DEFAULT_ERROR_SAMPLING_PERIOD = 10000; Review Comment: can you please help elaborate on this default value. is this value hardcoded? is this value overridable by a config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org